Reject non-mimepart resources in mailparse_msg_* instead of crashing#65
Closed
iliaal wants to merge 1 commit into
Closed
Reject non-mimepart resources in mailparse_msg_* instead of crashing#65iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by #70, reopened from the fork (iliaal/pecl-mail-mailparse). Branch should not have been pushed to php/ directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Five functions crash the PHP process when handed a resource that is not a mimepart, for example
mailparse_msg_parse(tmpfile(), "x").mailparse_fetch_mimepart_resourceexpands tozend_fetch_resource, which returns NULL (and raises aTypeErroron PHP 8) when the resource type does not match. The functions used the result without checking, so the following call dereferenced NULL:mailparse_msg_parse,mailparse_msg_get_structure,mailparse_msg_get_part_data,mailparse_msg_get_part, and themailparse_msg_extract_part*family.The object-method path already NULL-checks the same fetch; only these procedural entry points did not.
Fix
Add
if (part == NULL) { RETURN_FALSE; }after each fetch, mirroring the existing guard inmimemsg_get_object. The pendingTypeError(PHP 8) or warning (PHP 7) then surfaces cleanly instead of a segfault.